Hello Angel Pons,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34556
to review the following change.
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
payloads/external/Yabits: Pass XGCCPATH
Pass `XGCCPATH` instead of individual programs as that is what the Makefile expects.
Change-Id: I3267ec5259e9d37b2f3b0b8c126d173fc8b5a3ca Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/external/Makefile.inc 1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/34556/1
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 9c34efa..df168f2 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -300,10 +300,7 @@
payloads/external/Yabits/uefi/build/uefi.elf yabits: $(MAKE) -C payloads/external/Yabits all \ - CC="$(CC_x86_32)" \ - LD="$(LD_x86_32)" \ - OBJCOPY="$(OBJCOPY_x86_32)" \ - AS="$(AS_x86_32)" \ + XGCCPATH="$(XGCCPATH)" \ CONFIG_YABITS_REVISION=$(CONFIG_YABITS_REVISION) \ CONFIG_YABITS_REVISION_ID=$(CONFIG_YABITS_REVISION_ID) \ CONFIG_YABITS_MASTER=$(CONFIG_YABITS_MASTER) \
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG@7 PS1, Line 7: Yabits It probably needs some way to get build-tested by Mr. Jenkins
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG@7 PS1, Line 7: Yabits
It probably needs some way to get build-tested by Mr. […]
You can add a respective .config to configs/. Not sure if the download works oob, though.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
Patch Set 1: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34556/1//COMMIT_MSG@7 PS1, Line 7: Yabits
You can add a respective .config to configs/. Not sure if the […]
It wouldn't download the payload yet, and what-jenkins-does intentionally sets the payload to none. I started work on testing the payloads a while back, I need to finish that.
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34556 )
Change subject: payloads/external/Yabits: Pass XGCCPATH ......................................................................
payloads/external/Yabits: Pass XGCCPATH
Pass `XGCCPATH` instead of individual programs as that is what the Makefile expects.
Change-Id: I3267ec5259e9d37b2f3b0b8c126d173fc8b5a3ca Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/34556 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Martin Roth martinroth@google.com --- M payloads/external/Makefile.inc 1 file changed, 1 insertion(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 9c34efa..df168f2 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -300,10 +300,7 @@
payloads/external/Yabits/uefi/build/uefi.elf yabits: $(MAKE) -C payloads/external/Yabits all \ - CC="$(CC_x86_32)" \ - LD="$(LD_x86_32)" \ - OBJCOPY="$(OBJCOPY_x86_32)" \ - AS="$(AS_x86_32)" \ + XGCCPATH="$(XGCCPATH)" \ CONFIG_YABITS_REVISION=$(CONFIG_YABITS_REVISION) \ CONFIG_YABITS_REVISION_ID=$(CONFIG_YABITS_REVISION_ID) \ CONFIG_YABITS_MASTER=$(CONFIG_YABITS_MASTER) \
-
Angel Pons (Code Review) -
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)