Change in coreboot[master]: soc/intel/alderlake: Implement function to map physical port to EC port - coreboot-gerrit

29 Mar 2022


      Attention is currently required from: Maulik V Vaghela.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port
......................................................................
Patch Set 16:
(1 comment)
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/53da7ef1_dbc1a97b 
PS16, Line 19: 	for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) {
             : 		if (i == typec_port) {
             :
...
Oh yeah I see, maybe it shoiuld be like […]
yeah, probably. Also, this could be common code. There's no need to duplicate that function for each platform... :S
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59666
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3735b7c7794b46123aba3beac8c0268ce72d658c
Gerrit-Change-Number: 59666
Gerrit-PatchSet: 16
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Michael Niewöhner foss@mniewoehner.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 21:12:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment