Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63023 )
Change subject: soc/mediatek/i2c.c: Remove unused variables ......................................................................
soc/mediatek/i2c.c: Remove unused variables
Change-Id: Iaa643feb76530cc74acf4d714d8a7f96709be1cf Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/63023 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rex-BC Chen rex-bc.chen@mediatek.com Reviewed-by: Hung-Te Lin hungte@chromium.org --- M src/soc/mediatek/common/i2c.c 1 file changed, 0 insertions(+), 9 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved Rex-BC Chen: Looks good to me, but someone else must approve
diff --git a/src/soc/mediatek/common/i2c.c b/src/soc/mediatek/common/i2c.c index b4386b9..ab7b0de 100644 --- a/src/soc/mediatek/common/i2c.c +++ b/src/soc/mediatek/common/i2c.c @@ -496,7 +496,6 @@ uint32_t max_clk_div = MAX_CLOCK_DIV; uint32_t clk_src, clk_div, step_cnt, sample_cnt; uint32_t l_step_cnt, l_sample_cnt; - uint32_t timing_reg_value, ltiming_reg_value; struct mtk_i2c *bus_ctrl;
if (bus >= I2C_BUS_NUMBER) { @@ -516,27 +515,19 @@ &l_step_cnt, &l_sample_cnt)) continue;
- timing_reg_value = (l_sample_cnt << 8) | l_step_cnt; - /* Set the high speed mode register */ if (mtk_i2c_calculate_speed(bus, clk_src, speed, &step_cnt, &sample_cnt)) continue;
- ltiming_reg_value = (l_sample_cnt << 6) | l_step_cnt | - (sample_cnt << 12) | (step_cnt << 9); bus_ctrl->ac_timing.inter_clk_div = (clk_div - 1) << 8 | (clk_div - 1); } else { if (mtk_i2c_calculate_speed(bus, clk_src, speed, &l_step_cnt, &l_sample_cnt)) continue;
- timing_reg_value = (l_sample_cnt << 8) | l_step_cnt; - /* Disable the high speed transaction */ bus_ctrl->ac_timing.hs = I2C_TIME_CLR_VALUE; - - ltiming_reg_value = (l_sample_cnt << 6) | l_step_cnt; }
break;