Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29814 )
Change subject: soc/intel/apollolake: use a named choice for power settings ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/29814/4/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/29814/4/src/soc/intel/apollolake/Kc... PS4, Line 366: setup set up
https://review.coreboot.org/c/coreboot/+/29814/4/src/soc/intel/apollolake/Kc... PS4, Line 369: p-state P-State
https://review.coreboot.org/c/coreboot/+/29814/4/src/soc/intel/apollolake/Kc... PS4, Line 364: Apollo Lake's power management can be configured in multiple ways: : By default the Running Average Power Limits (RAPL) algorithm can : setup power management reasonably. : Some hardware can also run without these limits, while for other, : the minimum CPU clock might be preferable as a default. : The OS can still override the configuration with a p-state driver. Add one blank line between paragraphs?