Change in coreboot[master]: mb/google/dedede/var/cret: Support LTE module - coreboot-gerrit

29 Mar 2021


      Attention is currently required from: Martin Roth, Dtrain Hsu, Henry Sun.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51844 )
Change subject: mb/google/dedede/var/cret: Support LTE module
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/cret/variant.c:
https://review.coreboot.org/c/coreboot/+/51844/comment/ba39e2b3_dd79e61f 
PS5, Line 18: Once the FW_CONFIG is provisioned, power off LTE module only under
            : 	 * the situation where it is stuffed.
Do all SKUs of Cret have LTE or are they expected to have LTE? If so, this comment can be removed.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51844
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14684bb30e46bf845a401649f56b16b60db379e8
Gerrit-Change-Number: 51844
Gerrit-PatchSet: 5
Gerrit-Owner: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alan Lee alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng ian_feng@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun henrysun@google.com
Gerrit-Comment-Date: Mon, 29 Mar 2021 17:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment