Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36706 )
Change subject: sb/lynxpoint: Use macros instead of hard-coded IDs ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... PS3, Line 2700: #define PCI_DEVICE_ID_INTEL_LPT_LP_LPC_VALUE 0x9c47 Why do we need _LPC in the names?
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... PS3, Line 3005: #define PCI_DEVICE_ID_INTEL_SPT_U_Y_PREMIUM_SATA 0x9d07 unrelated
https://review.coreboot.org/c/coreboot/+/36706/3/src/include/device/pci_ids.... PS3, Line 3148: #define PCI_DEVICE_ID_INTEL_APL_HWSEQ_SPI 0x5a96 unrelated...
https://review.coreboot.org/c/coreboot/+/36706/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/usb_ehci.c:
https://review.coreboot.org/c/coreboot/+/36706/3/src/southbridge/intel/lynxp... PS3, Line 200: PCI_DEVICE_ID_INTEL_LPT_LP_EHCI, Order changed, causes a binary difference.
-
Nico Huber (Code Review)