[XS] Change in coreboot[main]: {lib, ec/google}: Add weak implementation for get_lid_switch()

[Subrata Banik (Code Review)]

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Jakub Czapiga, Julius Werner, Nick Vaccaro, Nick Vaccaro, Yu-Ping Wu.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78076?usp=email )

Change subject: {lib, ec/google}: Add weak implementation for  get_lid_switch()
......................................................................

Patch Set 2:

(1 comment)

File src/ec/google/chromeec/switches.c:

https://review.coreboot.org/c/coreboot/+/78076/comment/a679070e_9e22563f :
PS1, Line 9: 	if (!CONFIG(VBOOT_LID_SWITCH))
> Do we still need this Kconfig at all? If we have a weak implementation for get_lid_switch() that always returns 1 (which makes it a no-op for vboot), should we just call it all the time on all boards?

The weak implementation (that returns 1 aka LID open) is meaningful for the platform w/o EC_GOOGLE_CHROMEEC_SWITCHES aka non-chromeos device. But this Kconfig is used for chromeos devices to specify if LID is attached or not. Ideally chromebox and chromebase shouldn't select VBOOT_LID_SWITCH hence, i have used https://review.coreboot.org/c/coreboot/+/78077/1/src/ec/google/chromeec/swit... to return 1 aka LID open for cases.