Jonathan Zhang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46712 )
Change subject: temp ......................................................................
temp
Change-Id: Ieb7ec255bb0ca528dad031b898643f94aeddb37f --- M src/mainboard/ocp/deltalake/romstage.c 1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/46712/1
diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c index aeb451f..f0cdd3d 100644 --- a/src/mainboard/ocp/deltalake/romstage.c +++ b/src/mainboard/ocp/deltalake/romstage.c @@ -62,7 +62,8 @@
/* * UnusedUpdSpace0[0] is reserved for Memory Refresh Watermark. - * Following code is effective when MemRefreshWaterMark patch is added to FSP. + * Following code is effective when MemRefreshWaterMark patch is added to FSP + * and when corresponding VPD variable is set. */ if (vpd_gets(FSPM_MEMREFRESHWATERMARK, val_str, VPD_LEN, VPD_RW_THEN_RO)) { val = (uint8_t)atol(val_str); @@ -73,11 +74,6 @@ } printk(BIOS_DEBUG, "Setting MemRefreshWatermark %d from VPD\n", val); mupd->FspmConfig.UnusedUpdSpace0[0] = val; - } else { - printk(BIOS_INFO, "Not able to get VPD %s, default set " - "MemRefreshWatermark to %d\n", FSPM_MEMREFRESHWATERMARK, - FSPM_MEMREFRESHWATERMARK_DEFAULT); - mupd->FspmConfig.UnusedUpdSpace0[0] = FSPM_MEMREFRESHWATERMARK_DEFAULT; } }
Jonathan Zhang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46712 )
Change subject: temp ......................................................................
Abandoned
This was submitted by mistake.