Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19540 )
Change subject: soc/intel/common/block: Add Intel common CPU code
......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu....
File src/soc/intel/common/block/cpu/cpu.c:
PS11, Line 124: #if IS_ENABLED(CONFIG_HAVE_SMI_HANDLER)
avoid #if use if (IS_ENABLED()) anyway you are having soft link
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/cpu/cpu_...
File src/soc/intel/common/block/cpu/cpu_early.c:
PS11, Line 106: set_pch_cpu_strap(nominal_ratio);
i guess this implementation differs between different socs.?
PS11, Line 316: ADDRESS + PM1_TMR);
80
https://review.coreboot.org/#/c/19540/11/src/soc/intel/common/block/include/...
File src/soc/intel/common/block/include/intelblocks/msr.h:
PS11, Line 65: #define PRMRR_PHYS_BASE_MSR 0x1f4
don't keep this into common, it may be different between socs in future.
--
To view, visit
https://review.coreboot.org/19540
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f80c42132d9ea738be4051d2395e9e51ac153f8
Gerrit-PatchSet: 11
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Cole Nelson
colex.nelson@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: dhaval v sharma
dhaval.v.sharma@intel.com
Gerrit-HasComments: Yes