Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 )
Change subject: soc/mediatek/mt8186: add pmif driver setting ......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63089/comment/ee9b86b3_3fe22534 PS2, Line 7: add pmif driver setting Fix pmif setting for low power mode
https://review.coreboot.org/c/coreboot/+/63089/comment/b8de4a3d_6722b71c PS2, Line 9: We encounter a issue of suspend fail, and the root cause is that : the default pmif register setting is not correct for low power : mode. Therefore, we add the correct setting of pmif low power. The current pmif register setting for low power mode is incorrect, which is causing suspend failure. Therefore, add pmif_spmi_set_lp_mode() to correct the setting.
File src/soc/mediatek/mt8186/include/soc/pmif.h:
https://review.coreboot.org/c/coreboot/+/63089/comment/88119278_76f78539 PS2, Line 8: _ MT8186
https://review.coreboot.org/c/coreboot/+/63089/comment/292bab34_b4a1e8a1 PS2, Line 14: spmi Just to confirm, does "spmi" mean System Power Management Interface?
-
Yu-Ping Wu (Code Review)