Attention is currently required from: Felix Singer, Andy Pont, Paul Menzel. Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59705 )
Change subject: mainboard/starlabs/labtop: Hook up Thunderbolt to CMOS ......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/starlabs/labtop/cmos.layout:
https://review.coreboot.org/c/coreboot/+/59705/comment/276753a0_d8bf1592 PS7, Line 33: 542 1 e 1 thunderbolt
Doesn't make any real difference but following the +8 for each new option then this should be 544
Done
File src/mainboard/starlabs/labtop/variants/tgl/devtree.c:
https://review.coreboot.org/c/coreboot/+/59705/comment/c584e618_8a8ef820 PS7, Line 57: /* Enable/Disable Thunderbolt based on CMOS settings */
Is the check of the value of "webcam" here a typo? If not, the comment needs expanding to explain t […]
Done
-
Sean Rhodes (Code Review)