Attention is currently required from: V Sowmya.
Vinay Kumar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54055 )
Change subject: soc/intel/alderlake: Configure FIVR, VR, Turbo ratios
......................................................................
Patch Set 6:
(1 comment)
This change is ready for review.
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/54055/comment/e0e815fa_1744673e
PS6, Line 315: params->IccMax[1] = 40;
These IccMax values are in 1/4 units and 282 SKU requires 80A and 40A. So these need to be changed to 320A and 160A respectively for Core and GT Iccmax. Please check and fix this. Thanks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d485872c8bae32f83ebf94bdaa4c6a793976ce7
Gerrit-Change-Number: 54055
Gerrit-PatchSet: 6
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Baieswara Reddy Sagili
baieswara.reddy.sagili@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kedar J. Karanje
kedar.j.karanje@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vinay Kumar
vinay.kumar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: vagdevi.p@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Comment-Date: Fri, 04 Jun 2021 07:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment