Pranava Y N has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83707?usp=email )
Change subject: mb/google/brya/var/nova: Remove USB Type-C port setting ......................................................................
mb/google/brya/var/nova: Remove USB Type-C port setting
Update the devicetree to remove USB Type-C port related setting as the design doesn't include a USB-C port.
BUG=b:348332200 TEST=Able to build google/nova
Change-Id: I4b4025bea41f67224ac35ff2077b1394f2c3e380 Signed-off-by: Pranava Y N pranavayn@google.com --- M src/mainboard/google/brya/variants/nova/overridetree.cb 1 file changed, 8 insertions(+), 29 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/83707/1
diff --git a/src/mainboard/google/brya/variants/nova/overridetree.cb b/src/mainboard/google/brya/variants/nova/overridetree.cb index 950bb9b..e68ea1d 100644 --- a/src/mainboard/google/brya/variants/nova/overridetree.cb +++ b/src/mainboard/google/brya/variants/nova/overridetree.cb @@ -5,6 +5,7 @@
register "sagv" = "SaGv_Enabled"
+ register "usb2_ports[0]" = "USB2_PORT_MID(OC_SKIP)" # Genesys USB2 Hub register "usb2_ports[1]" = "USB2_PORT_EMPTY" # Disable USB2 Port 1 register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A3 register "usb2_ports[3]" = "USB2_PORT_MID(OC_SKIP)" # Type-A Port A2 @@ -30,6 +31,10 @@ register "usb3_ports[2]" = "USB3_PORT_EMPTY" # Disable Type-A port register "usb3_ports[3]" = "USB3_PORT_EMPTY" # Disable Type-A port
+ register "tcss_ports[0]" = "TCSS_PORT_EMPTY" + register "tcss_ports[1]" = "TCSS_PORT_EMPTY" + register "tcss_ports[2]" = "TCSS_PORT_EMPTY" + register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, [PchSerialIoIndexI2C1] = PchSerialIoPci, @@ -247,42 +252,16 @@ device ref gspi1 off end device ref pch_espi on chip ec/google/chromeec - use conn0 as mux_conn[0] device pnp 0c09.0 on end end end - device ref pmc hidden - chip drivers/intel/pmc_mux - device generic 0 on - chip drivers/intel/pmc_mux/conn - use usb2_port1 as usb2_port - use tcss_usb3_port1 as usb3_port - device generic 0 alias conn0 on end - end - end - end - end - device ref tcss_xhci on - chip drivers/usb/acpi - device ref tcss_root_hub on - chip drivers/usb/acpi - register "desc" = ""USB3 Type-C Port C0 (MLB)"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, CENTER, ACPI_PLD_GROUP(1, 0))" - device ref tcss_usb3_port1 on end - end - end - end - end + device ref pmc hidden end device ref xhci on chip drivers/usb/acpi device ref xhci_root_hub on chip drivers/usb/acpi - register "desc" = ""USB2 Type-C Port C0 (MLB)"" - register "type" = "UPC_TYPE_C_USB2_SS_SWITCH" - register "use_custom_pld" = "true" - register "custom_pld" = "ACPI_PLD_TYPE_C(BACK, CENTER, ACPI_PLD_GROUP(1, 0))" + register "desc" = ""USB2 Genesys Hub"" + register "type" = "UPC_TYPE_INTERNAL" device ref usb2_port1 on end end chip drivers/usb/acpi