Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78288?usp=email )
Change subject: drivers/pc80/rtc/option.c: Stop resetting CMOS during s3 resume
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS4:
Interesting. If I understand correctly, this EC BRAM is more than a scratchpad […]
Yes, that's right. Agree on refining restore that way too, I hope to give it a try but with a long TODO list and the immediate need solved by this change I have not had a chance yet. I'd be happy to review any patch if someone has the bandwidth to put it together.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78288?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I533e83f3b95f327b0e24f4d750f8812325b7770b
Gerrit-Change-Number: 78288
Gerrit-PatchSet: 8
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 20:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-MessageType: comment