Attention is currently required from: Hung-Te Lin, Angel Pons, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60795 )
Change subject: mb/google/herobrine: Ensure board ID GPIOs are set
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/60795/comment/aaf1d789_242e99d7
PS1, Line 25: dead_code();
This is reached for `BOARD_GOOGLE_HEROBRINE_REV0`, which seems to be deprecated. […]
Sorry about that. It seems that this change landed very close to the deprecation of HEROBRINE_REV0 so it didn't account for that. Here is the fix for it: https://review.coreboot.org/c/coreboot/+/60805
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I863cd7acc31442333d8f73d1bd3a77f5c9978020
Gerrit-Change-Number: 60795
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 05 Jan 2022 21:18:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment