[M] Change in coreboot[main]: soc/intel/common/block: Add support for watchdog

[Subrata Banik (Code Review)]

Attention is currently required from: Jakub Czapiga, Marek Maślanka, Michał Żygowski.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79909?usp=email )

Change subject: soc/intel/common/block: Add support for watchdog
......................................................................

Patch Set 13:

(3 comments)

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/4190f296_8d6a6543 :
PS12, Line 461: 11
> I replaced it with a function that takes the offset from a given field register definition to make i […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/79909/comment/45355ca5_3ab65b64 :
PS12, Line 468: 	entry->action = ACPI_WDAT_SET_RUNNING_STATE;
              : 	entry->instruction = ACPI_WDAT_WRITE_VALUE | ACPI_WDAT_PRESERVE_REGISTER;
              : 	entry->mask = 0x01;
              : 	entry->register_region.space_id = ACPI_ADDRESS_SPACE_IO;
              : 	entry->register_region.addrl = tcobase + TCO1_CNT;
              : 	entry->register_region.access_size = ACPI_WDAT_ACCESS_SIZE_WORD;
              : 	entry->register_region.bit_offset = 11;
> I would prefer to keep it consistent with filling in other entries instead of creating separate functions for that.

i'm unable to understand what u mean by "consistent with filling in other entries". Having a helper function can help improving the code readability as there are redundant programming except the `action` type being different

File src/soc/intel/common/block/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/79909/comment/ec56f76b_ee7f4b7b :
PS13, Line 396: rightmost_bit_offset
i'm unable to follow which right most bit u r considering ? may be a little meaningful name with the details about what this helper will do ?