Paul Menzel (paulepanter@users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18520
-gerrit
commit 88565be48b55b58f115edb9985e5665296edb25a Author: Paul Menzel paulepanter@users.sourceforge.net Date: Tue Feb 28 20:23:37 2017 +0100
ec/lenovo/h8: Use older syntax for bit shift
Currently, when using `iasl` from Debian 8 (Jessie/stable), the build of the Lenovo X60 fails with the error below.
``` Intel ACPI Component Architecture ASL Optimizing Compiler version 20140926-32 [Oct 1 2014] Copyright (c) 2000 - 2014 Intel Corporation
Compiler aborting due to parser-detected syntax error(s) dsdt.aml 1698: Return (TBSW << 3) Error 6126 - ^ Invalid character (0x3C), expecting ASL keyword or name
Store (DHKN, EMSK) dsdt.aml 1698: Return (TBSW << 3) Error 6126 - ^ Invalid character (0x3C), expecting ASL keyword or name
dsdt.aml 1698: Return (TBSW << 3) Error 6126 - ^ syntax error, unexpected PARSEOP_INTEGER, expecting ')'
ASL Input: dsdt.aml - 2405 lines, 42862 bytes, 1000 keywords
Compilation complete. 3 Errors, 0 Warnings, 0 Remarks, 0 Optimizations ```
ASL 2.0 supports `<<`. For consistency, right now, coreboot still uses the old syntax. So use `ShiftLeft` instead, which also fixes the build issue with older ASL compilers.
Change-Id: Id7e309c31612387da3920cf7d846b358ac2bdc71 Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net --- src/ec/lenovo/h8/acpi/ec.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl index b8350ad..ed62afe 100644 --- a/src/ec/lenovo/h8/acpi/ec.asl +++ b/src/ec/lenovo/h8/acpi/ec.asl @@ -363,7 +363,7 @@ Device(EC) /* Report tablet mode switch state */ Method (MHKG, 0, NotSerialized) { - Return (TBSW << 3) + Return (ShiftLeft(TBSW, 3)) } /* Mute audio */ Method (SSMS, 1, NotSerialized)
-
Paul Menzel