Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro.
Subrata Banik has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86255?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/uldrenite/variant.c:
https://review.coreboot.org/c/coreboot/+/86255/comment/d7522fd3_fe2d1949?usp... : PS2, Line 67: if (fw_config_probe(FW_CONFIG(DB_CELLULAR, CELLULAR_ABSENT))) { : return; : /* : * RW350R power on seuqence: : * De-assert WWAN_EN -> 20ms -> de-assert WWAN_RST -> 30ms -> : * de-assert WWAN_PERST : */ : gpio_configure_pads(rw350r_en_pad, ARRAY_SIZE(rw350r_en_pad)); : mdelay(RW350R_RST_DELAY_MS); : gpio_configure_pads(rw350r_rst_pad, ARRAY_SIZE(rw350r_rst_pad)); : mdelay(RW350R_PERST_DELAY_MS); : gpio_configure_pads(rw350r_perst_pad, ARRAY_SIZE(rw350r_perst_pad)); : } ```suggestion if (fw_config_probe(FW_CONFIG(DB_CELLULAR, CELLULAR_ABSENT))) return; /* * RW350R power on seuqence: * De-assert WWAN_EN -> 20ms -> de-assert WWAN_RST -> 30ms -> * de-assert WWAN_PERST */ gpio_configure_pads(rw350r_en_pad, ARRAY_SIZE(rw350r_en_pad)); mdelay(RW350R_RST_DELAY_MS); gpio_configure_pads(rw350r_rst_pad, ARRAY_SIZE(rw350r_rst_pad)); mdelay(RW350R_PERST_DELAY_MS); gpio_configure_pads(rw350r_perst_pad, ARRAY_SIZE(rw350r_perst_pad)); ```