Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD ......................................................................
mb/google/kefka: Add missing SPD
Adapted from Chromium commit 9522225e [Kefka: Add memory SPD info for Hynix H9CCNNN8GTALAR-NUD]
Add current available ram_id to support Hynix H9CCNNN8GTALAR-NUD spd info. RAM_ID: 0110 4GiB Hynix H9CCNNN8GTALAR-NUD RAM_ID: 0111 2GiB Hynix H9CCNNN8GTALAR-NUD
Original-Change-Id: I48386ff3e5f80de94ea87359a09a5ec2577043b5 Original-Signed-off-by: Peggy Chuang peggychuang@ami.corp-partner.google.com Original-Reviewed-on: https://chromium-review.googlesource.com/664517 Original-Reviewed-by: Aaron Durbin adurbin@chromium.org
Change-Id: I0ae76c4d8313246927bbc3f71b21f3611c89a6e3 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/cyan/variants/kefka/Makefile.inc M src/mainboard/google/cyan/variants/kefka/spd_util.c 2 files changed, 12 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/37901/1
diff --git a/src/mainboard/google/cyan/variants/kefka/Makefile.inc b/src/mainboard/google/cyan/variants/kefka/Makefile.inc index 7799e8d..d37ba1d 100644 --- a/src/mainboard/google/cyan/variants/kefka/Makefile.inc +++ b/src/mainboard/google/cyan/variants/kefka/Makefile.inc @@ -28,6 +28,8 @@ SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107 SPD_SOURCES += samsung_2GiB_dimm_K4E8E324EB-EGCF SPD_SOURCES += samsung_2GiB_dimm_K4E8E324EB-EGCF +SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD +SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD
SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
diff --git a/src/mainboard/google/cyan/variants/kefka/spd_util.c b/src/mainboard/google/cyan/variants/kefka/spd_util.c index d9adb72..9db56b9 100644 --- a/src/mainboard/google/cyan/variants/kefka/spd_util.c +++ b/src/mainboard/google/cyan/variants/kefka/spd_util.c @@ -25,10 +25,13 @@ * 0b0011 - 2GiB total - 1 x 2GiB Micron MT52L256M32D1PF-107 * 0b0100 - 4GiB total - 2 x 2GiB Samsung K4E8E324EB-EGCF 1600MHz * 0b0101 - 2GiB total - 1 x 2GiB Samsung K4E8E324EB-EGCF 1600MHz + * 0b0110 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8GTALAR-NUD + * 0b0111 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8GTALAR-NUD * */
-static const uint32_t dual_channel_config = (1 << 0) | (1 << 2) | (1 << 4); +static const uint32_t dual_channel_config = + (1 << 0) | (1 << 2) | (1 << 4) | (1 << 6);
int get_variant_spd_index(int ram_id, int *dual) { @@ -55,6 +58,12 @@ case 5: printk(BIOS_DEBUG, "2GiB Samsung K4E8E324EB-EGCF\n"); break; + case 6: + printk(BIOS_DEBUG, "4GiB Hynix H9CCNNN8GTALAR-NUD\n"); + break; + case 7: + printk(BIOS_DEBUG, "2GiB Hynix H9CCNNN8GTALAR-NUD\n"); + break; }
/* 1:1 mapping between ram_id and spd_index for kefka */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... File src/mainboard/google/cyan/variants/kefka/spd_util.c:
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... PS1, Line 33: static const uint32_t dual_channel_config = I think this still fits in 96 chars
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... File src/mainboard/google/cyan/variants/kefka/spd_util.c:
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... PS1, Line 33: static const uint32_t dual_channel_config =
I think this still fits in 96 chars
lint yelled at me so I changed it :)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD ......................................................................
mb/google/kefka: Add missing SPD
Adapted from Chromium commit 9522225e [Kefka: Add memory SPD info for Hynix H9CCNNN8GTALAR-NUD]
Add current available ram_id to support Hynix H9CCNNN8GTALAR-NUD spd info. RAM_ID: 0110 4GiB Hynix H9CCNNN8GTALAR-NUD RAM_ID: 0111 2GiB Hynix H9CCNNN8GTALAR-NUD
Original-Change-Id: I48386ff3e5f80de94ea87359a09a5ec2577043b5 Original-Signed-off-by: Peggy Chuang peggychuang@ami.corp-partner.google.com Original-Reviewed-on: https://chromium-review.googlesource.com/664517 Original-Reviewed-by: Aaron Durbin adurbin@chromium.org
Change-Id: I0ae76c4d8313246927bbc3f71b21f3611c89a6e3 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37901 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/cyan/variants/kefka/Makefile.inc M src/mainboard/google/cyan/variants/kefka/spd_util.c 2 files changed, 12 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/cyan/variants/kefka/Makefile.inc b/src/mainboard/google/cyan/variants/kefka/Makefile.inc index 7799e8d..d37ba1d 100644 --- a/src/mainboard/google/cyan/variants/kefka/Makefile.inc +++ b/src/mainboard/google/cyan/variants/kefka/Makefile.inc @@ -28,6 +28,8 @@ SPD_SOURCES += micron_dimm_MT52L256M32D1PF-107 SPD_SOURCES += samsung_2GiB_dimm_K4E8E324EB-EGCF SPD_SOURCES += samsung_2GiB_dimm_K4E8E324EB-EGCF +SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD +SPD_SOURCES += hynix_dimm_H9CCNNN8GTALAR-NUD
SPD_DEPS := $(foreach f, $(SPD_SOURCES), src/mainboard/$(MAINBOARDDIR)/spd/$(f).spd.hex)
diff --git a/src/mainboard/google/cyan/variants/kefka/spd_util.c b/src/mainboard/google/cyan/variants/kefka/spd_util.c index d9adb72..9db56b9 100644 --- a/src/mainboard/google/cyan/variants/kefka/spd_util.c +++ b/src/mainboard/google/cyan/variants/kefka/spd_util.c @@ -25,10 +25,13 @@ * 0b0011 - 2GiB total - 1 x 2GiB Micron MT52L256M32D1PF-107 * 0b0100 - 4GiB total - 2 x 2GiB Samsung K4E8E324EB-EGCF 1600MHz * 0b0101 - 2GiB total - 1 x 2GiB Samsung K4E8E324EB-EGCF 1600MHz + * 0b0110 - 4GiB total - 2 x 2GiB Hynix H9CCNNN8GTALAR-NUD + * 0b0111 - 2GiB total - 1 x 2GiB Hynix H9CCNNN8GTALAR-NUD * */
-static const uint32_t dual_channel_config = (1 << 0) | (1 << 2) | (1 << 4); +static const uint32_t dual_channel_config = + (1 << 0) | (1 << 2) | (1 << 4) | (1 << 6);
int get_variant_spd_index(int ram_id, int *dual) { @@ -55,6 +58,12 @@ case 5: printk(BIOS_DEBUG, "2GiB Samsung K4E8E324EB-EGCF\n"); break; + case 6: + printk(BIOS_DEBUG, "4GiB Hynix H9CCNNN8GTALAR-NUD\n"); + break; + case 7: + printk(BIOS_DEBUG, "2GiB Hynix H9CCNNN8GTALAR-NUD\n"); + break; }
/* 1:1 mapping between ram_id and spd_index for kefka */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... File src/mainboard/google/cyan/variants/kefka/spd_util.c:
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v... PS1, Line 33: static const uint32_t dual_channel_config =
lint yelled at me so I changed it :)
The lint on your machine? Maybe it needs to be updated. Meh, not a big deal
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)