Change in coreboot[master]: sb/intel/i82801i/jx/chip.h: Use unsigned ints for bitfields - coreboot-gerrit

24 Mar 2022


      Attention is currently required from: Arthur Heymans, Angel Pons.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63024 )
Change subject: sb/intel/i82801i/jx/chip.h: Use unsigned ints for bitfields
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/southbridge/intel/i82801jx/chip.h:
https://review.coreboot.org/c/coreboot/+/63024/comment/5e151032_b8ce6275 
PS2, Line 48: c5_enable
[Out of topic] 
looks like that c5_enable is always set to 1
(same for c6_enable).... 
so why we rewrite 1 here "src/mainboard/lenovo/t400/devicetree.cb" ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d6c333bb884ebc0ae50c4437f2cd98e74cf7379
Gerrit-Change-Number: 63024
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur.heymans@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 19:18:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment