Change in ...coreboot[master]: superio: Add ASpeed AST2400

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23135 )

Change subject: superio: Add ASpeed AST2400
......................................................................

Patch Set 23:

(3 comments)

https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... 
File src/superio/aspeed/ast2400/ast2400.h:

https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... 
PS20, Line 31: void pnp_enter_ext_func_mode(pnp_devfn_t dev);
> <device/pnp_type. […]

Done

https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/ast2400/ast2400.... 
PS20, Line 34: void aspeed2400_enable_serial(u16 port, u16 device, u16 iobase);
> <stdint. […]

Done

https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/common/early_ser... 
File src/superio/aspeed/common/early_serial.c:

https://review.coreboot.org/#/c/23135/20/src/superio/aspeed/common/early_ser... 
PS20, Line 50: 	outb(ASPEED_ENTRY_KEY, port);
> You want <arch/io.h> for this.

Done