Attention is currently required from: Martin L Roth, Marshall Dawson, Andrey Petrov, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51061 )
Change subject: drivers/intel/fsp2_0: Add support for locating specific HOB instance
......................................................................
Patch Set 4: Verified+1
(1 comment)
File src/drivers/intel/fsp2_0/hand_off_block.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-161208):
https://review.coreboot.org/c/coreboot/+/51061/comment/87d7442a_f180272d
PS4, Line 220: return fsp_find_extension_hob_inst_by_guid (guid, size, 0);
space prohibited between function name and open parenthesis '('
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51061
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I695f0d1574a59e65f01d12561a2c2f6142cac44d
Gerrit-Change-Number: 51061
Gerrit-PatchSet: 4
Gerrit-Owner: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 25 Oct 2022 01:06:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment