Change in coreboot[master]: mb/up/squared: do LPC/eSPI pad configuration at board-level - coreboot-gerrit

16 Jan 2021


      Attention is currently required from: Tim Wawrzynczak, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49414 )
Change subject: mb/up/squared: do LPC/eSPI pad configuration at board-level
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/up/squared/bootblock.c:
https://review.coreboot.org/c/coreboot/+/49414/comment/5183a2a1_86ca121e 
PS1, Line 6: #include "gpio.h"
...
If I didn't miss anything, there's not a single board doing it like that, so I wouldn't start incons […]
Never too late to set a good example ;)
I would just rename this file to `early_gpio.c` ^^
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/49414
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0693a4419c58dde3c4536698940f03c30304b9d
Gerrit-Change-Number: 49414
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Comment-Date: Sat, 16 Jan 2021 18:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de
Gerrit-MessageType: comment