Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29423 )
Change subject: src/soc/intel/braswell/southcluster.c: Configure IO APIC ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/29423/3/src/soc/intel/braswell/southcluster.... File src/soc/intel/braswell/southcluster.c:
https://review.coreboot.org/#/c/29423/3/src/soc/intel/braswell/southcluster.... PS3, Line 76: CONFIG_CBFS_SIZE That's only correct if vboot is disabled. You need to use the whole bios region. Is it required for proper operation ?
https://review.coreboot.org/#/c/29423/3/src/soc/intel/braswell/southcluster.... PS3, Line 104: )(IO_APIC_ADDR) Adding a macro to access IO_APIC (like the RCBA macro) would make the code more readable.
-
Patrick Rudolph (Code Review)