Attention is currently required from: Raul Rangel, Aaron Durbin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50341 )
Change subject: security/vboot/bootmode: Add weak fill_lb_gpios
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/security/vboot/bootmode.c:
https://review.coreboot.org/c/coreboot/+/50341/comment/e6a790b3_22488cce
PS1, Line 78: }
void function return statements are not generally useful
I'd remove the `return` statement and leave the function body empty.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42ca8f0dba9fd4a868bc7b636e4ed04cbf8dfab0
Gerrit-Change-Number: 50341
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Sun, 07 Feb 2021 14:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment