Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Marshall Dawson, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50339 )
Change subject: soc/amd/cezanne: Add root_complex
......................................................................
Patch Set 1:
(3 comments)
File src/soc/amd/cezanne/root_complex.c:
https://review.coreboot.org/c/coreboot/+/50339/comment/4aa97bf0_e6e74c44
PS1, Line 23: reserved_dram_end
To avoid having so much empty space on the left margin, how about moving this to the right side?
https://review.coreboot.org/c/coreboot/+/50339/comment/ea8d2c39_5b5566ab
PS1, Line 88: 1MB
nit: MiB
https://review.coreboot.org/c/coreboot/+/50339/comment/8206460c_2732ae3b
PS1, Line 97: *
nit: remove this `*` to comply with the coding style
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50339
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52682ec2a06c7e219c221648f241e18e26a9358e
Gerrit-Change-Number: 50339
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 07 Feb 2021 14:48:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment