Change in coreboot[master]: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47225 )
Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz ......................................................................
mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz
The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: Ie1ef95bb39d71fbb113120a0ec88305bc23e7ab9 --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/47225/1
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index bb4db53..1cb0b52 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -39,6 +39,12 @@ }, .i2c[3] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 153, + .scl_hcnt = 75, + .sda_hold = 36, + }, }, .i2c[5] = { .speed = I2C_SPEED_FAST,
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47225 )
Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47225 )
Change subject: mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz ......................................................................
mb/google/volteer/variants/volteer2: Tune I2C3 camera bus freq 400 kHz
The current I2C3 bus frequency is 341 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C3 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C3 frequency is 394kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: Ie1ef95bb39d71fbb113120a0ec88305bc23e7ab9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47225 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/variants/volteer2/overridetree.cb 1 file changed, 6 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb index bb4db53..1cb0b52 100644 --- a/src/mainboard/google/volteer/variants/volteer2/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer2/overridetree.cb @@ -39,6 +39,12 @@ }, .i2c[3] = { .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 153, + .scl_hcnt = 75, + .sda_hold = 36, + }, }, .i2c[5] = { .speed = I2C_SPEED_FAST,
-
Caveh Jalali (Code Review) -
Johnny Li (Code Review)
-
Patrick Georgi (Code Review)