Change in coreboot[master]: libpayload: storage.c: remove unneeded #if CONFIG()

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47248 ) Change subject: libpayload: storage.c: remove unneeded #if CONFIG() ...................................................................... libpayload: storage.c: remove unneeded #if CONFIG() Change-Id: I6e5679f66840105b3f9628071ac7aace9128107f Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com> --- M payloads/libpayload/drivers/storage/storage.c 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/47248/1 diff --git a/payloads/libpayload/drivers/storage/storage.c b/payloads/libpayload/drivers/storage/storage.c index a3b31c5..4b585ba 100644 --- a/payloads/libpayload/drivers/storage/storage.c +++ b/payloads/libpayload/drivers/storage/storage.c @@ -28,9 +28,7 @@ #include <libpayload.h> #include <pci/pci.h> -#if CONFIG(LP_STORAGE_AHCI) -# include <storage/ahci.h> -#endif +#include <storage/ahci.h> #include <storage/storage.h> static storage_dev_t **devices = NULL; -- To view, visit https://review.coreboot.org/c/coreboot/+/47248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5679f66840105b3f9628071ac7aace9128107f Gerrit-Change-Number: 47248 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src@posteo.de> Gerrit-MessageType: newchange

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47248 ) Change subject: libpayload: storage.c: remove unneeded #if CONFIG() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/47248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5679f66840105b3f9628071ac7aace9128107f Gerrit-Change-Number: 47248 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Thu, 05 Nov 2020 15:35:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47248 ) Change subject: libpayload: storage.c: remove unneeded #if CONFIG() ...................................................................... libpayload: storage.c: remove unneeded #if CONFIG() Change-Id: I6e5679f66840105b3f9628071ac7aace9128107f Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/47248 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Nico Huber <nico.h@gmx.de> --- M payloads/libpayload/drivers/storage/storage.c 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved diff --git a/payloads/libpayload/drivers/storage/storage.c b/payloads/libpayload/drivers/storage/storage.c index a3b31c5..4b585ba 100644 --- a/payloads/libpayload/drivers/storage/storage.c +++ b/payloads/libpayload/drivers/storage/storage.c @@ -28,9 +28,7 @@ #include <libpayload.h> #include <pci/pci.h> -#if CONFIG(LP_STORAGE_AHCI) -# include <storage/ahci.h> -#endif +#include <storage/ahci.h> #include <storage/storage.h> static storage_dev_t **devices = NULL; -- To view, visit https://review.coreboot.org/c/coreboot/+/47248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e5679f66840105b3f9628071ac7aace9128107f Gerrit-Change-Number: 47248 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src@posteo.de> Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net> Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (3)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Thomas Heijligen (Code Review)