Attention is currently required from: Dengwu Yu, Karthik Ramasubramanian, Kun Liu, Shelley Chen, Subrata Banik, Wentao Qin.
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83051?usp=email )
Change subject: mb/google/brox/var/lotso: Update devicetree setting ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/brox/variants/lotso/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83051/comment/7442d1db_cbde075a?usp... : PS4, Line 7: field STORAGE 2 3 : option STORAGE_UNKNOWN 0 : option STORAGE_UFS 1 : option STORAGE_NVME 2 : end
STORAGE bits have moved from bit 0 to bit 2. This is going to break the proto builds. […]
Now, we still in proto phases, and bit 2 3 for storage is right way.
Ref: https://chrome-internal-review.googlesource.com/c/chromeos/project/brox/lots...
https://review.coreboot.org/c/coreboot/+/83051/comment/326567e8_f82b3d78?usp... : PS4, Line 169: device ref pch_espi on : chip ec/google/chromeec : device pnp 0c09.0 on end : end : end
Not required since it is already enabled in base devicetree. […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83051/comment/5fbf6980_fed22130?usp... : PS4, Line 307: probe WIFI_BT WIFI_PCIE_WIFI7
I don't think this duplicate probe is required since the probe failure on pcie_rp5 will disable any […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/83051/comment/2f08f871_534078e3?usp... : PS4, Line 345: probe ISH ISH_ENABLE
last time I spoke, I was told ISH is not going to be used. […]
Acknowledged