Marty E. Plummer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35082 )
Change subject: arch/ppc64: move misc.c to qemu-power8 as timer.c ......................................................................
arch/ppc64: move misc.c to qemu-power8 as timer.c
Its entirely no-op and is getting in the way of real hardware timers for power9/talos ii.
Change-Id: I2d21d4ac3d1a7d3f099ed6ec4faf10079b1ee1d1 Signed-off-by: Marty E. Plummer hanetzer@startmail.com --- M src/arch/ppc64/Makefile.inc M src/mainboard/emulation/qemu-power8/Makefile.inc R src/mainboard/emulation/qemu-power8/timer.c 3 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/35082/1
diff --git a/src/arch/ppc64/Makefile.inc b/src/arch/ppc64/Makefile.inc index 03b455a..bb9c63dd 100644 --- a/src/arch/ppc64/Makefile.inc +++ b/src/arch/ppc64/Makefile.inc @@ -85,7 +85,6 @@
ramstage-y += rom_media.c ramstage-y += stages.c -ramstage-y += misc.c ramstage-y += boot.c ramstage-y += tables.c ramstage-y += \ diff --git a/src/mainboard/emulation/qemu-power8/Makefile.inc b/src/mainboard/emulation/qemu-power8/Makefile.inc index db005bb..5c6c56e 100644 --- a/src/mainboard/emulation/qemu-power8/Makefile.inc +++ b/src/mainboard/emulation/qemu-power8/Makefile.inc @@ -17,6 +17,7 @@ romstage-y += cbmem.c ramstage-y += cbmem.c romstage-y += romstage.c +ramstage-y += timer.c romstage-y += uart.c ramstage-y += uart.c
diff --git a/src/arch/ppc64/misc.c b/src/mainboard/emulation/qemu-power8/timer.c similarity index 100% rename from src/arch/ppc64/misc.c rename to src/mainboard/emulation/qemu-power8/timer.c
Timothy Pearson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35082 )
Change subject: arch/ppc64: move misc.c to qemu-power8 as timer.c ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35082 )
Change subject: arch/ppc64: move misc.c to qemu-power8 as timer.c ......................................................................
arch/ppc64: move misc.c to qemu-power8 as timer.c
Its entirely no-op and is getting in the way of real hardware timers for power9/talos ii.
Change-Id: I2d21d4ac3d1a7d3f099ed6ec4faf10079b1ee1d1 Signed-off-by: Marty E. Plummer hanetzer@startmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35082 Reviewed-by: Timothy Pearson tpearson@raptorengineering.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/arch/ppc64/Makefile.inc M src/mainboard/emulation/qemu-power8/Makefile.inc R src/mainboard/emulation/qemu-power8/timer.c 3 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Timothy Pearson: Looks good to me, approved
diff --git a/src/arch/ppc64/Makefile.inc b/src/arch/ppc64/Makefile.inc index ac993d7..fae4c92 100644 --- a/src/arch/ppc64/Makefile.inc +++ b/src/arch/ppc64/Makefile.inc @@ -77,7 +77,6 @@
ramstage-y += rom_media.c ramstage-y += stages.c -ramstage-y += misc.c ramstage-y += boot.c ramstage-y += tables.c ramstage-y += \ diff --git a/src/mainboard/emulation/qemu-power8/Makefile.inc b/src/mainboard/emulation/qemu-power8/Makefile.inc index db005bb..5c6c56e 100644 --- a/src/mainboard/emulation/qemu-power8/Makefile.inc +++ b/src/mainboard/emulation/qemu-power8/Makefile.inc @@ -17,6 +17,7 @@ romstage-y += cbmem.c ramstage-y += cbmem.c romstage-y += romstage.c +ramstage-y += timer.c romstage-y += uart.c ramstage-y += uart.c
diff --git a/src/arch/ppc64/misc.c b/src/mainboard/emulation/qemu-power8/timer.c similarity index 100% rename from src/arch/ppc64/misc.c rename to src/mainboard/emulation/qemu-power8/timer.c
-
Marty E. Plummer (Code Review) -
Patrick Georgi (Code Review)
-
Timothy Pearson (Code Review)