Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Karthik Ramasubramanian.
Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68325 )
Change subject: mb/google/skyrim: Store XHCI PCI BARs
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/google/skyrim/mainboard.c:
https://review.coreboot.org/c/coreboot/+/68325/comment/ef6f545e_e5995106
PS6, Line 133: const struct device *xhci[] = {
: DEV_PTR(xhci_0),
: DEV_PTR(xhci_1),
: DEV_PTR(xhci_2)
: };
any reason to put this inside the function rather than above the function?
Done
https://review.coreboot.org/c/coreboot/+/68325/comment/97993eb5_bba1d6ca
PS6, Line 138:
What about returning if elog isn't enabled? […]
What's the concern with not returning early? If ELOG isn't selected then the BARs will be stored, but won't be used.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68325
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I529f541a8932267a8825773ddc582beafb27da63
Gerrit-Change-Number: 68325
Gerrit-PatchSet: 11
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 28 Nov 2022 23:25:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-MessageType: comment