Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86332?usp=email )
Change subject: mb/starlabs/*: Use a safe configurations for DRAM Sleep GPIO ......................................................................
mb/starlabs/*: Use a safe configurations for DRAM Sleep GPIO
The configuration used was copied from other boards in the tree, NF1/NF2. However, no Intel documents says that GPP_E8 has a native function.
As it remains unclear if the other boards in the tree are misconfiugured, or the documents are incorrect, revert to a safe configuration for the GPIO.
Change-Id: I49b8faa7f8712ad0ead22b7ccbfa6deca6046368 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/86332 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 6 files changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index f17e3ae..8ec1666 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -256,7 +256,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_NC(GPP_E8, NONE), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index fb3d64d..2ab629f 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -255,7 +255,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_CFG_NF(GPP_E8, NONE, DEEP, NF1), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index b59ad9d..835d8f6 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -255,7 +255,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_CFG_NF(GPP_E8, NONE, DEEP, NF2), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index e8c2550..5e3cd00 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -255,7 +255,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_CFG_NF(GPP_E8, NONE, DEEP, NF1), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 18c5651..a69b210 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -260,7 +260,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_CFG_NF(GPP_E8, NONE, DEEP, NF1), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 4ca0ca5..edde160 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -254,7 +254,7 @@ /* E7: Embedded Controller SMI */ PAD_NC(GPP_E7, NONE), /* E8: DRAM Sleep */ - PAD_CFG_NF(GPP_E8, NONE, DEEP, NF2), + PAD_CFG_GPO(GPP_E8, 1, DEEP), /* E9: USB OverCurrent 0 */ PAD_NC(GPP_E9, NONE), /* E10: PWD Amplifier Input */