Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33046
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
nb/intel/nehalem: Call smm_region_start() function
TEST: X201 Boots again.
Change-Id: Ia637bd01cd7dc1aecd1a87a739d5243c70419553 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/ram_calc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33046/1
diff --git a/src/northbridge/intel/nehalem/ram_calc.c b/src/northbridge/intel/nehalem/ram_calc.c index ca821da..f0b848d 100644 --- a/src/northbridge/intel/nehalem/ram_calc.c +++ b/src/northbridge/intel/nehalem/ram_calc.c @@ -35,7 +35,7 @@
u32 northbridge_get_tseg_base(void) { - return (u32)smm_region_start & ~1; + return (u32)smm_region_start() & ~1; }
void *cbmem_top(void)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33046 )
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33046
to look at the new patch set (#2).
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
nb/intel/nehalem: Call smm_region_start() function
TEST: X201 Boots again.
Change-Id: Ia637bd01cd7dc1aecd1a87a739d5243c70419553 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/ram_calc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33046/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33046 )
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33046 )
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/#/c/33046/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33046/2//COMMIT_MSG@7 PS2, Line 7: nb/intel/nehalem: Call smm_region_start() function it does more than that now
https://review.coreboot.org/#/c/33046/2/src/northbridge/intel/nehalem/ram_ca... File src/northbridge/intel/nehalem/ram_calc.c:
https://review.coreboot.org/#/c/33046/2/src/northbridge/intel/nehalem/ram_ca... PS2, Line 38: return (u32)smm_region_start(); maybe it should be the other way around, smm_region_start() calling northbridge_get_tseg_base(), then you wouldn't need the cast here. otoh, then you could also manually inline smm_region_start() below and would need a cast there ;)
Hello Angel Pons, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33046
to look at the new patch set (#3).
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
nb/intel/nehalem: Call smm_region_start() function
This also removes the unnecessary mask.
TEST: X201 Boots again.
Change-Id: Ia637bd01cd7dc1aecd1a87a739d5243c70419553 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/nehalem/ram_calc.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/33046/3
Arthur Heymans has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33046 )
Change subject: nb/intel/nehalem: Call smm_region_start() function ......................................................................
nb/intel/nehalem: Call smm_region_start() function
This also removes the unnecessary mask.
TEST: X201 Boots again.
Change-Id: Ia637bd01cd7dc1aecd1a87a739d5243c70419553 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33046 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Nico Huber nico.h@gmx.de --- M src/northbridge/intel/nehalem/ram_calc.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/nehalem/ram_calc.c b/src/northbridge/intel/nehalem/ram_calc.c index ca821da..e32190f 100644 --- a/src/northbridge/intel/nehalem/ram_calc.c +++ b/src/northbridge/intel/nehalem/ram_calc.c @@ -35,7 +35,7 @@
u32 northbridge_get_tseg_base(void) { - return (u32)smm_region_start & ~1; + return (u32)smm_region_start(); }
void *cbmem_top(void)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Nico Huber (Code Review)