Change in coreboot[master]: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS M...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Michał Żygowski (Code Review)

7 May 2020 7 May '20

1:22 p.m.

Michał Żygowski has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile

The hardware IRQ option was not passed to SeaBIOS Makefile and resulted in HARDWARE_IRQ being permanently disabled regardless of Kconfig selection in coreboot. On platforms that need the hardware IRQ it caused hangs at boot menu or iPXE prompts.

TEST=enter SeaBIOS boot menu on Libretrend LT1000

Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 --- M payloads/external/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/41147/1

diff --git a/payloads/external/Makefile.inc b/payloads/external/Makefile.inc index 7319a11..5274581 100644 --- a/payloads/external/Makefile.inc +++ b/payloads/external/Makefile.inc @@ -102,7 +102,8 @@ CONFIG_SEABIOS_DEBUG_LEVEL=$(CONFIG_SEABIOS_DEBUG_LEVEL) \ CONFIG_DRIVERS_UART_8250MEM_32=$(CONFIG_DRIVERS_UART_8250MEM_32) \ CONFIG_ENABLE_HSUART=$(CONFIG_ENABLE_HSUART) \ - CONFIG_CONSOLE_UART_BASE_ADDRESS=$(CONFIG_CONSOLE_UART_BASE_ADDRESS) + CONFIG_CONSOLE_UART_BASE_ADDRESS=$(CONFIG_CONSOLE_UART_BASE_ADDRESS) \ + CONFIG_SEABIOS_HARDWARE_IRQ=$(CONFIG_SEABIOS_HARDWARE_IRQ)

payloads/external/SeaBIOS/seabios/out/vgabios.bin: payloads/external/SeaBIOS/seabios/out/bios.bin.elf payloads/external/SeaBIOS/seabios/.config: payloads/external/SeaBIOS/seabios/out/bios.bin.elf

Attachments:

attachment.htm (text/html — 3.1 KB)

Show replies by date

Michał Żygowski (Code Review)

7 May 7 May

1:23 p.m.

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1:

Hi Matt, please test ASAP. It break almost all boards with SeaBIOS payload. We missed to pass the Kconfig option to SeaBIOS Makefile in the previous patch.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Comment-Date: Thu, 07 May 2020 13:23:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Matt DeVillier (Code Review)

3:47 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 May 2020 15:47:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Matt DeVillier (Code Review)

3:51 p.m.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1:

this was in my original local patch for CB:39869, not sure how it got lost. Sorry about that!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 May 2020 15:51:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:04 p.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 May 2020 16:04:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

4:06 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 May 2020 16:06:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

4:08 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 07 May 2020 16:08:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4:16 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile

TEST=enter SeaBIOS boot menu on Libretrend LT1000

Signed-off-by: Michał Żygowski michal.zygowski@3mdeb.com Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41147 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com --- M payloads/external/Makefile.inc 1 file changed, 2 insertions(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Nico Huber: Looks good to me, approved Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, approved

payloads/external/SeaBIOS/seabios/out/vgabios.bin: payloads/external/SeaBIOS/seabios/out/bios.bin.elf payloads/external/SeaBIOS/seabios/.config: payloads/external/SeaBIOS/seabios/out/bios.bin.elf

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

4:31 p.m.

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41147 )

Change subject: payloads/external/Makefile.inc: Pass hardware IRQ option to SeaBIOS Makefile ......................................................................

Patch Set 2:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3257 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3256 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3255 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3254

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/41147 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iafcfd743177bbcd1ee23e227c74dd8268c4c23c6 Gerrit-Change-Number: 41147 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Thu, 07 May 2020 16:31:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1466

days inactive

1466

days old

coreboot-gerrit@coreboot.org

8 comments

6 participants

tags (0)

participants (6)

9elements QA (Code Review)
Angel Pons (Code Review)
Matt DeVillier (Code Review)
Michał Żygowski (Code Review)
Nico Huber (Code Review)
Patrick Georgi (Code Review)