Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41029 )
Change subject: soc/intel/jasperlake: Add Sata related UPDs configuration ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs... File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs... PS6, Line 139: dev->enabled
changed. […]
Now that SataEnable is dropped here, it should also be dropped from chip.h? https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/jasperlake/...
https://review.coreboot.org/c/coreboot/+/41029/6/src/soc/intel/jasperlake/fs... PS6, Line 140: SataEnable
added all upds. […]
Done