Attention is currently required from: Fred Reitberger, Jason Glenesk, Marshall Dawson, Matt DeVillier, Nick Kochlowski, Paul Menzel.
Felix Held has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85195?usp=email )
Change subject: soc/amd/phoenix/pci_irq_routing.c: Populate PCI IRQ routing table
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
File src/soc/amd/phoenix/pci_irq_routing.c:
https://review.coreboot.org/c/coreboot/+/85195/comment/0642ec9f_e00447ff?usp... :
PS9, Line 35:
one empty line is sufficient
https://review.coreboot.org/c/coreboot/+/85195/comment/ad710b8a_f17e04ca?usp... :
PS9, Line 48:
i'd mention here that while there is a 1:1 mapping of those two sets of registers on phoenix, it's not necessarily the case on other socs. just to clarify that this code might not be just moved to the common code as-is, but that this is a special case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85195?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id014ff3e675831eec42bc46c0a76271341e0e3e4
Gerrit-Change-Number: 85195
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Kochlowski
nickkochlowski@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 19:53:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes