Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30383 )
Change subject: soc/intel/broadwell: Use C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 39:
(1 comment)
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig
File src/soc/intel/broadwell/Kconfig:
https://review.coreboot.org/#/c/30383/37/src/soc/intel/broadwell/Kconfig@117
PS37, Line 117: default 0x2000
I think the linker tells you if that is not enough?
It can only be statically decided if there is no dynamic stack
usage, e.g. local array with a size given by a function parameter.
I don't know if we got rid of it.
Oh, does the MRC use our stack?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44eb6d380dea5b82e3f009a46381a0f611bb7935
Gerrit-Change-Number: 30383
Gerrit-PatchSet: 39
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 12 May 2019 10:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment