Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52873 )
Change subject: soc/intel/{adl,tgl,jsl}: Add smihandler_soc_disable_busmaster
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52873/comment/f4f09459_d08c548a
PS4, Line 7: soc/intel/{adl, tgl, jsl}: Don't disable bus master on PMC device in sleep smi
:
: We found system hang if the shutdown is triggered before fsps.
: This is due to the io decode enable on pmc is disabled by
: busmaster_disable_on_bus function.
: Hence, the slp_en on acpi pm1_cnt register doesn't succeed.
: So this change skip pmc bus disable before shutdown.
:
: The reason issue is not reproduced after fsps is beacause pmc pci
: device is hidden after fsps.
: That's why busmaster_disable_on_bus won't clear io deocde on pmc device.
suggestion: […]
thanks for your suggestion.
i've changed the commit msg.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52873
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1cf5cf91ebad4a49df6679e01fc88ff60c81526c
Gerrit-Change-Number: 52873
Gerrit-PatchSet: 5
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 02:46:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment