Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Kane Chen, Karthik Ramasubramanian.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52874 )
Change subject: soc/intel/{adl,tgl,jsl}: Enable power button smi after BS_CHIPS_EXIT
......................................................................
Patch Set 6:
(2 comments)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/01d1b6f2_147d8a08
PS5, Line 101: /*
: * Now that all APs have been relocated as well as the BSP let SMIs
: * start flowing.
: */
Can you please update all of these comments as to the reason why the `_no_powrbtn` variant is used h […]
done
File src/soc/intel/alderlake/pmc.c:
https://review.coreboot.org/c/coreboot/+/52874/comment/893b31d4_a96a3f77
PS5, Line 148: (FSPS)
nit: space after `(`, also please spell it `FSP-S`
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52874
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I70b871f2676a89bc782116e02beba5c20ec51eef
Gerrit-Change-Number: 52874
Gerrit-PatchSet: 6
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 05 May 2021 02:45:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment