HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34067 )
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
crossgcc: Upgrade acpica to version 20190703
Changes: https://acpica.org/node/171
Change-Id: I3883718623e4a23a901a446f738a9e8c988d8433 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch D util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34067/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 327027a..4c1a6da 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.32 GDB_VERSION=8.2.1 -IASL_VERSION=20190509 +IASL_VERSION=20190703 PYTHON_VERSION=3.7.2 EXPAT_VERSION=2.2.6 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20190509_iasl.patch b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch similarity index 73% rename from util/crossgcc/patches/acpica-unix2-20190509_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20190703_iasl.patch index 49df225..0f60974 100644 --- a/util/crossgcc/patches/acpica-unix2-20190509_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch @@ -1,6 +1,6 @@ -diff -Naur acpica-unix2-20190509_/source/compiler/asloptions.c acpica-unix2-20190509/source/compiler/asloptions.c > acpica-unix2-20190509_iasl.patch ---- acpica-unix2-20190509_/source/compiler/asloptions.c -+++ acpica-unix2-20190509/source/compiler/asloptions.c +diff -Naur acpica-unix2-20190703_/source/compiler/asloptions.c acpica-unix2-20190703/source/compiler/asloptions.c > acpica-unix2-20190703_iasl.patch +--- acpica-unix2-20190703_/source/compiler/asloptions.c ++++ acpica-unix2-20190703/source/compiler/asloptions.c @@ -126,6 +126,7 @@ if (Gbl_DoSignon) { diff --git a/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum deleted file mode 100644 index 2f53d71..0000000 --- a/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -aa4d4f8051800e84a5ed5b71635594aaca749e8d tarballs/acpica-unix2-20190509.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum new file mode 100644 index 0000000..9a89796 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum @@ -0,0 +1 @@ +c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34067 )
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
Patch Set 1: Code-Review+1
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34067
to look at the new patch set (#2).
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
crossgcc: Upgrade acpica to version 20190703
Changes: https://acpica.org/node/171
Change-Id: I3883718623e4a23a901a446f738a9e8c988d8433 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch D util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34067/2
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34067
to look at the new patch set (#3).
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
crossgcc: Upgrade acpica to version 20190703
Changes: https://acpica.org/node/171
Change-Id: I3883718623e4a23a901a446f738a9e8c988d8433 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch D util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum 4 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34067/3
Hello Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34067
to look at the new patch set (#4).
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
crossgcc: Upgrade acpica to version 20190703
Changes: https://acpica.org/node/171
Change-Id: I3883718623e4a23a901a446f738a9e8c988d8433 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch D util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34067/4
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34067 )
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
Patch Set 5:
Do all boards build? (Does Jenkins rebuild the tool chain for tool chain changes?)
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34067 )
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
Patch Set 5: Code-Review+2
Patch Set 5:
Do all boards build? (Does Jenkins rebuild the tool chain for tool chain changes?)
Yes and Yes. If you look in the jenkins responses, for toolchain changes, we have 3 builds. The normal coreboot-gerrit and coreboot-checkpatch builds happen, but when anything in the crossgcc directory changes, we also get a coreboot-toolchain build. This takes a really long time because it builds the entire toolchain for all architectures, then builds coreboot using the new toolchain.
https://qa.coreboot.org/job/coreboot-gerrit/99382/ : SUCCESS
https://qa.coreboot.org/job/coreboot-toolchain/607/ : SUCCESS
https://qa.coreboot.org/job/coreboot-checkpatch/52032/ : SUCCESS
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34067 )
Change subject: crossgcc: Upgrade acpica to version 20190703 ......................................................................
crossgcc: Upgrade acpica to version 20190703
Changes: https://acpica.org/node/171
Change-Id: I3883718623e4a23a901a446f738a9e8c988d8433 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34067 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/crossgcc/buildgcc R util/crossgcc/patches/acpica-unix2-20190703_iasl.patch D util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum A util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum 4 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc index 0f141ea..30062e8 100755 --- a/util/crossgcc/buildgcc +++ b/util/crossgcc/buildgcc @@ -54,7 +54,7 @@ GCC_AUTOCONF_VERSION=2.69 BINUTILS_VERSION=2.32 GDB_VERSION=8.3 -IASL_VERSION=20190509 +IASL_VERSION=20190703 PYTHON_VERSION=3.7.4 EXPAT_VERSION=2.2.7 # CLANG version number diff --git a/util/crossgcc/patches/acpica-unix2-20190509_iasl.patch b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch similarity index 73% rename from util/crossgcc/patches/acpica-unix2-20190509_iasl.patch rename to util/crossgcc/patches/acpica-unix2-20190703_iasl.patch index 49df225..0f60974 100644 --- a/util/crossgcc/patches/acpica-unix2-20190509_iasl.patch +++ b/util/crossgcc/patches/acpica-unix2-20190703_iasl.patch @@ -1,6 +1,6 @@ -diff -Naur acpica-unix2-20190509_/source/compiler/asloptions.c acpica-unix2-20190509/source/compiler/asloptions.c > acpica-unix2-20190509_iasl.patch ---- acpica-unix2-20190509_/source/compiler/asloptions.c -+++ acpica-unix2-20190509/source/compiler/asloptions.c +diff -Naur acpica-unix2-20190703_/source/compiler/asloptions.c acpica-unix2-20190703/source/compiler/asloptions.c > acpica-unix2-20190703_iasl.patch +--- acpica-unix2-20190703_/source/compiler/asloptions.c ++++ acpica-unix2-20190703/source/compiler/asloptions.c @@ -126,6 +126,7 @@ if (Gbl_DoSignon) { diff --git a/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum deleted file mode 100644 index 2f53d71..0000000 --- a/util/crossgcc/sum/acpica-unix2-20190509.tar.gz.cksum +++ /dev/null @@ -1 +0,0 @@ -aa4d4f8051800e84a5ed5b71635594aaca749e8d tarballs/acpica-unix2-20190509.tar.gz diff --git a/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum new file mode 100644 index 0000000..9a89796 --- /dev/null +++ b/util/crossgcc/sum/acpica-unix2-20190703.tar.gz.cksum @@ -0,0 +1 @@ +c5594944f933265a53695204a0672d0808e4a580 tarballs/acpica-unix2-20190703.tar.gz
-
HAOUAS Elyes (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)