Change in ...coreboot[master]: sb/amd/sb700: Fix misleading formatting

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33268

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

sb/amd/sb700: Fix misleading formatting

Change-Id: I65872d6f1d71d050c8589d3616340648cf95048b
Signed-off-by: Marshall Dawson 
---
M src/southbridge/amd/sb700/sm.c
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/33268/1

diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c
index 6b7ce68..6631682 100644
--- a/src/southbridge/amd/sb700/sm.c
+++ b/src/southbridge/amd/sb700/sm.c
@@ -306,7 +306,7 @@
    }
    byte = pci_read_config8(dev, 0xAE);
    if (CONFIG(ENABLE_APIC_EXT_ID))
-	byte |= 1 << 4;
+		byte |= 1 << 4;
    byte |= 1 << 5;	/* ACPI_DISABLE_TIMER_IRQ_ENHANCEMENT_FOR_8254_TIMER */
    byte |= 1 << 6;	/* Enable arbiter between APIC and PIC interrupts */
    pci_write_config8(dev, 0xAE, byte);

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33268 )

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33268 )

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

Patch Set 1: Code-Review+2

I'm still very much in favor of not allowing single line if statements without curly braces around them ;)

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33268 )

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

Patch Set 1: Code-Review+2
> Patch Set 1: Code-Review+2
>
> I'm still very much in favor of not allowing single line if statements without curly braces around them ;)

I agree.  Let's bring it up at the next leadership meeting.

We've got conflicting guidelines right now anyway - single lines after if or else statements don't get braces unless the else has multiple lines.

Let's just always have braces.  It adds an extra line, but it makes situations like this completely clear.

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33268 )

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

Patch Set 1: Code-Review+1

[Marshall Dawson (Code Review)]

Marshall Dawson has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33268 )

Change subject: sb/amd/sb700: Fix misleading formatting
......................................................................

sb/amd/sb700: Fix misleading formatting

Change-Id: I65872d6f1d71d050c8589d3616340648cf95048b
Signed-off-by: Marshall Dawson 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33268
Tested-by: build bot (Jenkins) 
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Felix Held 
Reviewed-by: Martin Roth 
Reviewed-by: HAOUAS Elyes 
---
M src/southbridge/amd/sb700/sm.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, approved
  Martin Roth: Looks good to me, approved
  Felix Held: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, but someone else must approve

diff --git a/src/southbridge/amd/sb700/sm.c b/src/southbridge/amd/sb700/sm.c
index 6b7ce68..6631682 100644
--- a/src/southbridge/amd/sb700/sm.c
+++ b/src/southbridge/amd/sb700/sm.c
@@ -306,7 +306,7 @@
    }
    byte = pci_read_config8(dev, 0xAE);
    if (CONFIG(ENABLE_APIC_EXT_ID))
-	byte |= 1 << 4;
+		byte |= 1 << 4;
    byte |= 1 << 5;	/* ACPI_DISABLE_TIMER_IRQ_ENHANCEMENT_FOR_8254_TIMER */
    byte |= 1 << 6;	/* Enable arbiter between APIC and PIC interrupts */
    pci_write_config8(dev, 0xAE, byte);