Patch Set 1: Code-Review+2

I'm still very much in favor of not allowing single line if statements without curly braces around them ;)

I agree. Let's bring it up at the next leadership meeting.

We've got conflicting guidelines right now anyway - single lines after if or else statements don't get braces unless the else has multiple lines.

Let's just always have braces. It adds an extra line, but it makes situations like this completely clear.

Patch set 1:Code-Review +2

View Change

To view, visit change 33268. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I65872d6f1d71d050c8589d3616340648cf95048b
Gerrit-Change-Number: 33268
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 07 Jun 2019 14:26:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment