[M] Change in coreboot[main]: mb/google/brox: Fix Booting to kernel without battery

[Paul Menzel (Code Review)]

Attention is currently required from: Eric Herrmann, Forest Mittelberg, Kapil Porwal, Karthik Ramasubramanian, Keith Short, Nick Vaccaro, Rishika Raj, Shelley Chen, Sowmya Aralguppe, Subrata Banik.

Paul Menzel has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/83752?usp=email )

Change subject: mb/google/brox: Fix Booting to kernel without battery
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/83752/comment/b181bf3d_cf95a9ac?usp... :
PS3, Line 9: Set Boot frequency UPD to 1 to avoid higher PL2 power draw when
           : only adaptor is connected with battery removed or disconnected.
           : Reduce PL4 value to overcome power spikes from SoC during boot.
           : Remove Psys implementation since it impacts active state platform
           : performance.
> Done

I didn’t see this.

1. Reduce …
2. Remove …

Or, if you do not want to enumerate things, please do not break lines after a sentence ends.

Commit Message:

https://review.coreboot.org/c/coreboot/+/83752/comment/a61124a9_a6f7e6bd?usp... :
PS4, Line 7: Booting
booting

https://review.coreboot.org/c/coreboot/+/83752/comment/5303e627_6191e65a?usp... :
PS4, Line 9: When battery is disconnected and only adaptor is connected
           : higher PL2 power draw causes cpu brown out and system does not
           : boot to kernel. To avoid this set Boot frequency UPD to 1.
           : Reduce PL4 value to overcome power spikes from SoC during boot.
           : Remove Psys implementation since it impacts active state
           : platform performance.
Please reflow for 72 characters per line.

File src/mainboard/google/brox/variants/brox/ramstage.c:

https://review.coreboot.org/c/coreboot/+/83752/comment/5e5e3753_336e95dc?usp... :
PS4, Line 19: 		.pl1_min_power = 15000,
Please also mention this (and below) in the commit message. Or did I miss it?