Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36353 )
Change subject: soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 platforms ......................................................................
soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 platforms
Set the FSP parameter PeiGraphicsPeimInit according to RUN_FSP_GOP to enable or skip GOP.
Change-Id: I5993e64631f86ff0f9ae069e10b89df8bc4cd085 Signed-off-by: Michael Niewöhner foss@mniewoehner.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/36353 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/soc/intel/icelake/fsp_params.c 1 file changed, 4 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/icelake/fsp_params.c b/src/soc/intel/icelake/fsp_params.c index 8819e7d..62c69da 100644 --- a/src/soc/intel/icelake/fsp_params.c +++ b/src/soc/intel/icelake/fsp_params.c @@ -94,15 +94,11 @@ mainboard_silicon_init_params(params);
dev = pcidev_path_on_root(SA_DEVFN_IGD); - - if (!dev || !dev->enabled) { - /* - * Skip IGD initialization in FSP in case device is disabled - * in the devicetree.cb. - */ - params->PeiGraphicsPeimInit = 0; - } else { + if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled) params->PeiGraphicsPeimInit = 1; + else + params->PeiGraphicsPeimInit = 0; + if (dev && dev->enabled) { params->GtFreqMax = 2; params->CdClock = 3; }