Change in coreboot[master]: intel/common/block: Fix issues found by klockwork - coreboot-gerrit

13 Aug 2018


      John Zhao has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in...
File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/28060/1/src/soc/intel/common/block/cpu/mp_in...
PS1, Line 137: assert
...
It will only avoid the null pointer being dereferenced *IF* fatal asserts are turned on. […]
Looks like CONFIG_FATAL_ASSERTS is on. If asserts fails, FILE/LINE are printed and code execution is halt.
-- 
To view, visit https://review.coreboot.org/28060
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7caa15a3911e05ff346d338493673af5318a51
Gerrit-Change-Number: 28060
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao john.zhao@intel.com
Gerrit-Reviewer: John Zhao john.zhao@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: AndreX Andraos andrex.andraos@intel.com
Gerrit-CC: Martin Roth martinroth@google.com
Gerrit-Comment-Date: Mon, 13 Aug 2018 23:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No