Change in ...coreboot[master]: nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31825
Change subject: nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h' ......................................................................
nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h'
Change-Id: I69ec0eb6af67c3f12b627de2903be26252e2b35b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/amd/amdfam10/util.c 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/31825/1
diff --git a/src/northbridge/amd/amdfam10/util.c b/src/northbridge/amd/amdfam10/util.c index 41f4deb..20e5910 100644 --- a/src/northbridge/amd/amdfam10/util.c +++ b/src/northbridge/amd/amdfam10/util.c @@ -41,13 +41,6 @@ #define CONF_ROUTE_START 0xe0 #define CONF_ROUTE_END 0xec
-#define PCI_IO_BASE0 0xc0 -#define PCI_IO_BASE1 0xc8 -#define PCI_IO_BASE2 0xd0 -#define PCI_IO_BASE3 0xd8 -#define PCI_IO_BASE_VGA_EN (1 << 4) -#define PCI_IO_BASE_NO_ISA (1 << 5) - #define BITS(r, shift, mask) (((r>>shift)&mask))
/**
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31825 )
Change subject: nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h' ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31825 )
Change subject: nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h' ......................................................................
nb/amd/amdfam10: Remove define macro already done in 'amdfam10.h'
Change-Id: I69ec0eb6af67c3f12b627de2903be26252e2b35b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/31825 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/northbridge/amd/amdfam10/util.c 1 file changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/northbridge/amd/amdfam10/util.c b/src/northbridge/amd/amdfam10/util.c index 41f4deb..20e5910 100644 --- a/src/northbridge/amd/amdfam10/util.c +++ b/src/northbridge/amd/amdfam10/util.c @@ -41,13 +41,6 @@ #define CONF_ROUTE_START 0xe0 #define CONF_ROUTE_END 0xec
-#define PCI_IO_BASE0 0xc0 -#define PCI_IO_BASE1 0xc8 -#define PCI_IO_BASE2 0xd0 -#define PCI_IO_BASE3 0xd8 -#define PCI_IO_BASE_VGA_EN (1 << 4) -#define PCI_IO_BASE_NO_ISA (1 << 5) - #define BITS(r, shift, mask) (((r>>shift)&mask))
/**
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)