Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Subrata Banik, Ronak Kanabar, Patrick Rudolph. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57141 )
Change subject: soc/intel/alderlake: Change VBOOT_HASH_BLOCK_SIZE to 4 KiB ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57141/comment/8b58f678_c27da9b9 PS3, Line 13: Increasing it over 4 KiB doesn't result in significant improvement, Just curious: When you say doesn't result in significant improvement, how much is the saving for 8/16/32KiB? Also, what is the current time it takes for hashing? Is it possible to add a table here documenting the time seen for 1/4/8/16/32KiB? I think it would be helpful in the future to look at the numbers as well.
https://review.coreboot.org/c/coreboot/+/57141/comment/8dc4bfde_e174f9cc PS3, Line 16: None Probably add the boot time bug here? It would be helpful when looking at all the optimizations that went in for improving boot time.
https://review.coreboot.org/c/coreboot/+/57141/comment/2d37a0c5_5a8c4d7e PS3, Line 18: 20 - 25 msec Nice!
-
Furquan Shaikh (Code Review)