Attention is currently required from: Angel Pons, Arthur Heymans, David Milosevic, Maximilian Brune, Nico Huber, Patrick Rudolph, Paul Menzel.
Naresh Solanki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79103?usp=email )
Change subject: mb/arm/rdn2: Add support for Arm Neoverse N2
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/arm/rdn2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/79103/comment/ceab570c_74c1f67b :
PS2, Line 22: return (size_t)probe_ramsize((uintptr_t)RDN2_DRAM2_BASE, RDN2_DRAM2_SIZE) * MiB;
reference firmware by default uses 6GB RAM for DRAM2 unless overridden by build parameter CFLAGS=-D […]
Memory info isn't available via TF pointers for Neoverse N2.
Hence RAM has to be probed for now. tested to work without any issues.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79103?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I17908d3ce773d4a88924bafb1d0e9e2a043c7fbc
Gerrit-Change-Number: 79103
Gerrit-PatchSet: 2
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 13 Dec 2023 17:08:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-MessageType: comment