Attention is currently required from: Benjamin Doron, Lean Sheng Tan.
Julius Werner has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/85643?usp=email )
Change subject: commonlib/device_tree.c: Add a function that reads FDT ints
......................................................................
Patch Set 6:
(1 comment)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85643/comment/bcf9f91d_389d1166?usp... :
PS6, Line 267: printk(BIOS_DEBUG, "FDT integer property of size %u @%p is %u cells\n", prop->size, prop->data, cells);
I don't think we'll want to print this every time, it's just gonna be spam.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85643?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I02d27eb5e23dfbfc1404d209ee8d60968e22bb80
Gerrit-Change-Number: 85643
Gerrit-PatchSet: 6
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Lean Sheng Tan
tanleansheng@outlook.com
Gerrit-Comment-Date: Fri, 03 Jan 2025 15:19:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No