Change in coreboot[master]: configs: Add a weird config for Asrock B85M Pro4

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

configs: Add a weird config for Asrock B85M Pro4

Please do not try to use it on real hardware. Or maybe do try.

Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Signed-off-by: Angel Pons 
---
A configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
1 file changed, 36 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/43977/1

diff --git a/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
new file mode 100644
index 0000000..e4d3b2f
--- /dev/null
+++ b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
@@ -0,0 +1,36 @@
+CONFIG_CCACHE=y
+CONFIG_COVERAGE=y
+CONFIG_UBSAN=y
+CONFIG_VENDOR_ASROCK=y
+CONFIG_ONBOARD_VGA_IS_PRIMARY=y
+CONFIG_CBFS_SIZE=0x200000
+CONFIG_BOARD_ASROCK_B85M_PRO4=y
+CONFIG_PCIEXP_L1_SUB_STATE=y
+CONFIG_PCIEXP_CLK_PM=y
+CONFIG_CONSOLE_POST=y
+# CONFIG_INTEL_CHIPSET_LOCKDOWN is not set
+# CONFIG_FINALIZE_USB_ROUTE_XHCI is not set
+CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y
+CONFIG_PCIEXP_HOTPLUG=y
+CONFIG_SMMSTORE=y
+CONFIG_SMMSTORE_SIZE=0x30000
+CONFIG_SPI_FLASH_NO_FAST_READ=y
+CONFIG_USBDEBUG=y
+CONFIG_USBDEBUG_DONGLE_FTDI_FT232H=y
+CONFIG_DRIVERS_SIL_3114=y
+# CONFIG_SQUELCH_EARLY_SMP is not set
+CONFIG_CONSOLE_SPI_FLASH=y
+CONFIG_POST_DEVICE_PCI_PCIE=y
+CONFIG_FATAL_ASSERTS=y
+CONFIG_DEBUG_CBFS=y
+CONFIG_DEBUG_SMBUS=y
+CONFIG_DEBUG_SMI=y
+CONFIG_DEBUG_PERIODIC_SMI=y
+CONFIG_DEBUG_MALLOC=y
+CONFIG_DEBUG_CONSOLE_INIT=y
+CONFIG_DEBUG_SPI_FLASH=y
+CONFIG_DEBUG_COVERAGE=y
+CONFIG_DEBUG_BOOT_STATE=y
+CONFIG_DEBUG_ADA_CODE=y
+CONFIG_HAVE_EM100_SUPPORT=y
+CONFIG_EM100=y

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

Maybe add one or several comment lines at the top of the file to describe the purpose of the config?

Something like

# Not meant for actual use. Exercises UBSAN, ...

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
PS1, Line 1: CONFIG_CCACHE=y
not sure we should enforce this in here?

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43977

to look at the new patch set (#2).

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

configs: Add a weird config for Asrock B85M Pro4

Please do not try to use it on real hardware. Or maybe do try.

Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Signed-off-by: Angel Pons 
---
A configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
1 file changed, 35 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/43977/2

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43977

to look at the new patch set (#3).

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

configs: Add a weird config for Asrock B85M Pro4

Please do not try to use it on real hardware. Or maybe do try.

Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Signed-off-by: Angel Pons 
---
A configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
1 file changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/43977/3

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
PS1, Line 1: CONFIG_CCACHE=y
> not sure we should enforce this in here?

Ah, this one slipped through (I unconditionally enable ccache through site-local, and made this defconfig by temporarily disabling my site-local Kconfig)

I guess I'll notice (and loudly complain) if ccache breaks anyway 😜

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:

https://review.coreboot.org/c/coreboot/+/43977/1/configs/config.asrock_b85m_... 
PS1, Line 1: CONFIG_CCACHE=y
> Ah, this one slipped through (I unconditionally enable ccache through site-local, and made this defc […]

Done

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43977/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43977/4//COMMIT_MSG@8 
PS4, Line 8: 
           : Please do not try to use it on real hardware. Or maybe do try.
Maybe mention something here about the purpose: coverage, UBSAN, etc.

[Angel Pons (Code Review)]

Hello build bot (Jenkins), Nico Huber, Patrick Georgi, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43977

to look at the new patch set (#5).

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

configs: Add a weird config for Asrock B85M Pro4

This config is meant to build-test several options, such as SMMSTORE,
UBSAN, SIL3114 driver, EM100 support, code coverage and debug options.
Please do not try to use it on real hardware. Or maybe do try.

Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Signed-off-by: Angel Pons 
---
A configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
1 file changed, 42 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/43977/5

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43977/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/43977/4//COMMIT_MSG@8 
PS4, Line 8: 
           : Please do not try to use it on real hardware. Or maybe do try.
> Maybe mention something here about the purpose: coverage, UBSAN, etc.

Done

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 5: Code-Review+1

[Arthur Heymans (Code Review)]

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 5: Code-Review+2

Quite surprising that all these options build.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

Patch Set 5:
> Patch Set 5: Code-Review+2
>
> Quite surprising that all these options build.

Well, I fixed some of these options 😄

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43977 )

Change subject: configs: Add a weird config for Asrock B85M Pro4
......................................................................

configs: Add a weird config for Asrock B85M Pro4

This config is meant to build-test several options, such as SMMSTORE,
UBSAN, SIL3114 driver, EM100 support, code coverage and debug options.
Please do not try to use it on real hardware. Or maybe do try.

Change-Id: I8bc19a1987b405d5a654276050b00b956acbdf36
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43977
Reviewed-by: Tim Wawrzynczak 
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
A configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
1 file changed, 42 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved
  Tim Wawrzynczak: Looks good to me, but someone else must approve

diff --git a/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
new file mode 100644
index 0000000..49e7901
--- /dev/null
+++ b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100
@@ -0,0 +1,42 @@
+# Not meant for actual use. Exercises, among other things:
+# + Code coverage
+# + UBSAN
+# + Debug options
+# + SMMSTORE
+# + Silicon Image SIL3114 driver
+# + EM100 support
+CONFIG_COVERAGE=y
+CONFIG_UBSAN=y
+CONFIG_VENDOR_ASROCK=y
+CONFIG_ONBOARD_VGA_IS_PRIMARY=y
+CONFIG_CBFS_SIZE=0x200000
+CONFIG_BOARD_ASROCK_B85M_PRO4=y
+CONFIG_PCIEXP_L1_SUB_STATE=y
+CONFIG_PCIEXP_CLK_PM=y
+CONFIG_CONSOLE_POST=y
+# CONFIG_INTEL_CHIPSET_LOCKDOWN is not set
+# CONFIG_FINALIZE_USB_ROUTE_XHCI is not set
+CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y
+CONFIG_PCIEXP_HOTPLUG=y
+CONFIG_SMMSTORE=y
+CONFIG_SMMSTORE_SIZE=0x30000
+CONFIG_SPI_FLASH_NO_FAST_READ=y
+CONFIG_USBDEBUG=y
+CONFIG_USBDEBUG_DONGLE_FTDI_FT232H=y
+CONFIG_DRIVERS_SIL_3114=y
+# CONFIG_SQUELCH_EARLY_SMP is not set
+CONFIG_CONSOLE_SPI_FLASH=y
+CONFIG_POST_DEVICE_PCI_PCIE=y
+CONFIG_FATAL_ASSERTS=y
+CONFIG_DEBUG_CBFS=y
+CONFIG_DEBUG_SMBUS=y
+CONFIG_DEBUG_SMI=y
+CONFIG_DEBUG_PERIODIC_SMI=y
+CONFIG_DEBUG_MALLOC=y
+CONFIG_DEBUG_CONSOLE_INIT=y
+CONFIG_DEBUG_SPI_FLASH=y
+CONFIG_DEBUG_COVERAGE=y
+CONFIG_DEBUG_BOOT_STATE=y
+CONFIG_DEBUG_ADA_CODE=y
+CONFIG_HAVE_EM100_SUPPORT=y
+CONFIG_EM100=y